Closed mileslucas closed 5 years ago
This looks fantastic, thanks! Happy to add you as a contributor to the RTD, though I had trouble finding mileslucas
there. Do you have a different username?
I had an old handle on a non-professional email, I just made a new account under mileslucas
so give it a try again.
This cleans up a lot of the unit tests, fixes regressions in the travis script as well as fixing read the docs auto-deployment. I managed to extremely bungle my git branches so this has one commit with a lot of changes from a manual reset.
Changelist:
tests
test_*.py
classnameTest*
and test methodstest_*
)tests/data
folder.travis.yml
:tests/data
to reduce integration test timeNote I ran into the same issues with timing out on the phoenix downloads. I opened a support ticket with travis ci to see if they had any ideas what was happening. To remedy this, in the meantime, I have marked the tests requiring this files to skip until it is resolved. I can confirm that the tests run locally as written. (#108)
read the docs
README.md
that shows the doc build statusconf.py
to make sure the RTD build would succeedSome larger picture things-
I have decided to make the minimum required python version
3.6
. I have two main reasons for this-3.6
includes format strings, which would help clean up a lot of the code, if we can enforcepython >= 3.6
we can take advantage of this across the code.I don't think this kind of change should be that big of an issue. I've never ran into an issue with requiring 3.6 in my other projects and if people are installing from pip it will all be handled for us automatically anyways. I've written changes into the
README.md
and docs that show this change as well, for consistency.