Starfish-develop / Starfish

Tools for Flexible Spectroscopic Inference
https://starfish.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
68 stars 22 forks source link

Remove Planck scaling of global covariance #145

Closed mileslucas closed 2 years ago

mileslucas commented 2 years ago

This PR removes the Planck scaling introduced by d629fbd376ec07c62fa0f9f6b3ed1b2b0be4245d

At the time, it worked very well for fitting infrared data over a large range (from 1 to 5 micron). It doesn't make sense, though, because the errors are not expected to scale like a blackbody.

Other notes: I had to update some of the version requirements in setup.py to get installs running smoothly, as well as the minimum python version because 3.6 isn't compatible with Github actions for some reason. I'm thinking of switching to using poetry for the library build file rather than setup.py to get away from some of the issues I was having, but I'll leave that for another day/PR.