search

StarkShang / vite-plugin-chrome-extension

A vite plugin to bundle chrome extensions for Manifest V3.
MIT License
460 stars 68 forks source link

fix(watch-mode): allow run plugin in watch mode #36

Open IvanRodriCalleja opened 1 year ago

IvanRodriCalleja commented 1 year ago

Fixes: https://github.com/StarkShang/vite-plugin-chrome-extension/issues/6

The problem with the watch mode was that the input for content script was not regenerated and the new manifest was wrong generated because the content script was not found in the bundle as a file.

@StarkShang Would you be open to review and release a new version in case you are agree with the fix or do you prefer that i fork the repo and maintain my own plugin?

salmin89 commented 1 year ago

I would love to get this merged. @IvanRodriCalleja did this work for your local env? got a sandbox project setup for testing that I can tryout?

I tried in my own with npm install github:IvanRodriCalleja/vite-plugin-chrome-extension#0dc5405 but didn't get it to work

IvanRodriCalleja commented 1 year ago

I had it working in my local with this changes but finally i migrated to @crxjs/vite-plugin

salmin89 commented 1 year ago

@IvanRodriCalleja good idea, I will do that to :)