search

StarlaneStudios / vscode-comment-anchors

⚓A Visual Studio Code extension that adds support for comment anchors 🔭
https://marketplace.visualstudio.com/items?itemName=ExodiusStudios.comment-anchors
MIT License
206 stars 32 forks source link

Keybinding conflict with `option c, key` #167

Closed stepelu closed 1 year ago

stepelu commented 1 year ago

I am using a customized keyboard (made with https://software.sil.org/ukelele/).

This extension produces some kind of conflict with the alt C + key combination.

Below I paste the logs registered via the Developer: Toggle Keyboard Shortcuts Troubleshooting command.

Pre-pended to each log chunk are is the unicode letter that should be produced, and the keyboard combination that should produce it.

μ <- option g, m
[2022-10-16 16:40:18.938] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltRight, keyCode: 18, key: Alt
[2022-10-16 16:40:18.939] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltRight, keyCode: 6 ('Alt')
[2022-10-16 16:40:18.940] [renderer1] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2022-10-16 16:40:19.113] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: KeyG, keyCode: 71, key: Dead
[2022-10-16 16:40:19.125] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: KeyG, keyCode: 37 ('G')
[2022-10-16 16:40:19.126] [renderer1] [info] [KeybindingService]: | Resolving alt+[KeyG]
[2022-10-16 16:40:19.126] [renderer1] [info] [KeybindingService]: \ No keybinding entries.
[2022-10-16 16:40:19.126] [renderer1] [info] [KeybindingService]: + Storing single modifier for possible chord alt.
[2022-10-16 16:40:19.165] [renderer1] [info] [KeybindingService]: + Clearing single modifier due to other key up.
[2022-10-16 16:40:19.231] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyM, keyCode: 77, key: μ
[2022-10-16 16:40:19.231] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyM, keyCode: 43 ('M')
[2022-10-16 16:40:19.232] [renderer1] [info] [KeybindingService]: | Resolving [KeyM]
[2022-10-16 16:40:19.232] [renderer1] [info] [KeybindingService]: \ From 1 keybinding entries, no when clauses matched the context.

𝕄 <- option b, m
[2022-10-16 16:41:24.953] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltRight, keyCode: 18, key: Alt
[2022-10-16 16:41:24.954] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltRight, keyCode: 6 ('Alt')
[2022-10-16 16:41:24.954] [renderer1] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2022-10-16 16:41:25.112] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: KeyB, keyCode: 66, key: Dead
[2022-10-16 16:41:25.113] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: KeyB, keyCode: 32 ('B')
[2022-10-16 16:41:25.114] [renderer1] [info] [KeybindingService]: | Resolving alt+[KeyB]
[2022-10-16 16:41:25.114] [renderer1] [info] [KeybindingService]: \ From 1 keybinding entries, no when clauses matched the context.
[2022-10-16 16:41:25.138] [renderer1] [info] [KeybindingService]: + Storing single modifier for possible chord alt.
[2022-10-16 16:41:25.164] [renderer1] [info] [KeybindingService]: + Clearing single modifier due to other key up.

ℳ <- option c, m
[2022-10-16 16:41:40.521] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: AltRight, keyCode: 18, key: Alt
[2022-10-16 16:41:40.556] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltRight, keyCode: 6 ('Alt')
[2022-10-16 16:41:40.557] [renderer1] [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
[2022-10-16 16:41:40.685] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [alt], code: KeyC, keyCode: 67, key: Dead
[2022-10-16 16:41:40.685] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: KeyC, keyCode: 33 ('C')
[2022-10-16 16:41:40.686] [renderer1] [info] [KeybindingService]: | Resolving alt+[KeyC]
[2022-10-16 16:41:40.686] [renderer1] [info] [KeybindingService]: \ From 2 keybinding entries, matched chord, when: editorTextFocus, source: user extension ExodiusStudios.comment-anchors.
[2022-10-16 16:41:40.689] [renderer1] [info] [KeybindingService]: + Entering chord mode...
[2022-10-16 16:41:40.718] [renderer1] [info] [KeybindingService]: + Storing single modifier for possible chord alt.
[2022-10-16 16:41:40.738] [renderer1] [info] [KeybindingService]: + Clearing single modifier due to other key up.
[2022-10-16 16:41:40.838] [renderer1] [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyM, keyCode: 77, key: ℳ
[2022-10-16 16:41:40.839] [renderer1] [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyM, keyCode: 43 ('M')
[2022-10-16 16:41:40.839] [renderer1] [info] [KeybindingService]: | Resolving [KeyM] chorded from alt+[KeyC]
[2022-10-16 16:41:40.840] [renderer1] [info] [KeybindingService]: \ From 0 keybinding entries, no when clauses matched the context.
[2022-10-16 16:41:40.840] [renderer1] [info] [KeybindingService]: + Leaving chord mode: Nothing bound to "⌥C M".

The last case should produce an ℳ, but fails to do so unless I disable this extension. I suspected of this extension due to the ExodiusStudios.comment-anchors line. Would it please be possible to make this extension keybindings fully configurable, or at least introduce an option to disable them?

Thank you

JordanDi123 commented 1 year ago

Hello,

Extension keybindings are already fully configurable from the vscode Keyboard Shortcuts page:

image

Hope this helps!