search

StarlaneStudios / vscode-comment-anchors

⚓A Visual Studio Code extension that adds support for comment anchors 🔭
https://marketplace.visualstudio.com/items?itemName=ExodiusStudios.comment-anchors
MIT License
212 stars 33 forks source link

feat: Now we can group and sort anchors #91

Closed eggachecat closed 4 years ago

eggachecat commented 4 years ago
eggachecat commented 4 years ago

image

eggachecat commented 4 years ago

@macjuul Hello would you like to do a code review for this? Thanks a lot!

eggachecat commented 4 years ago

BTW @macjuul should we configure some lint rules for this project in case many of us could have different default coding styles.

macjuul commented 4 years ago

Will give the PR a review in the near future, currently caught up in some busy tasks for the moment. At a quick glance it looks promising and mostly ready to be merged 👍

Linting rules would be a great addition, however I've always struggled getting ESLint to work and end up getting rid of it all together. If you have any suggestions for it feel free to let me know or open a separate PR.

Thanks!

eggachecat commented 4 years ago

UPDATE: I am using this extension with this feature to learn the source code of react, the performance is just fine😎😎. And I realized that maybe putting chapter into epic may be a good idea

eggachecat commented 4 years ago

TODO: right-click-context-menu would be a great option for sorting

macjuul commented 4 years ago

Heyo! Just checking in. Looks like the latest PR merge caused some conflicts. I'll take care of merging this PR once they are resolved and you're confident grouping and sorting is ready 🙂

eggachecat commented 4 years ago

@macjuul just make another PR to resolve the previous PR conflict. Would you like to do a code review?

BTW, should we make the default value of maxFiles larger up to something like 500? Sometimes it really is confusing when the extension misses some anchors in a large repo.

macjuul commented 4 years ago

I've upped the maxFiles limit to 250 for now and fixed some inconsistencies around it.

I did run into some issues getting ESLint to work, and I had to fix some issues for it to calm down, however it caused some conflicts on your branch, so I quickly fixed those too.

I'll give this branch some additional testing before merging it, although it's looking good! 🙂

macjuul commented 4 years ago

Hey! I've tested your branch and everything seems to work great, and I really appreciate your PR!

One minor change I made was to remove the default Epic and instead opt to not display untagged anchors in the tree in order to keep epics more streamlined, as it may have been confusing to new users. Other than that everything's good to go!

eggachecat commented 4 years ago

@macjuul Great! Nice work!! BTW I cannot find the latest version from vscode , would you like to publish it? Can not wait for sharing(showing off :-)) it with my colleagues!

macjuul commented 4 years ago

@eggachecat I'll release the new version shortly (hopefully today) along with some other minor changes