search

StarlaneStudios / vscode-comment-anchors

⚓A Visual Studio Code extension that adds support for comment anchors 🔭
https://marketplace.visualstudio.com/items?itemName=ExodiusStudios.comment-anchors
MIT License
212 stars 33 forks source link

fix: #96 #99

Closed eggachecat closed 4 years ago

eggachecat commented 4 years ago
  1. Previously we forgot calling return(callsuccess) in the scenario that hasKeyWord is false. (Thus the promise hangs)
  2. We don't need promise here since there's nothing async in this function
eggachecat commented 4 years ago

@macjuul Hello, would you like to do a Code Review for this one?

eggachecat commented 4 years ago

BTW the prettier is weriod.. It keeps asking me to add semicolon

macjuul commented 4 years ago

Thanks for the quick fix!

I'll try and get this released later today 🙂