search

Starlight-JS / starlight

JS engine in Rust
https://teletype.in/@starlight-js
Mozilla Public License 2.0
511 stars 9 forks source link

feat: add finally return support #60

Open jameslahm opened 3 years ago

jameslahm commented 3 years ago

Fix #7

playXE commented 3 years ago

Oh wow! That's nice work! But seems like there's some regression as now half of previously passing test262 tests do not pass:

Results:
Total tests: 78695
Passed tests: 6187
Ignored tests: 24233
Failed tests: 48275 (panics: 1497)
Conformance: 7.86%

dev branch: 

Results:
Total tests: 78695
Passed tests: 12579
Ignored tests: 24233
Failed tests: 41883 (panics: 1244)
Conformance: 15.98%

EDIT: You can see how much tests pass in Actions

jameslahm commented 3 years ago

Hi, I encountered a segment fault error when I run sl examples/hello-world.js without .startupshot. I feel like there has some problem in add_conservative in gc.rs. Do you have this problem?

jameslahm commented 3 years ago

It seems that I found it. I will push and try to run test262.

playXE commented 3 years ago

Hi, I encountered a segment fault error when I run sl examples/hello-world.js without .startupshot. I feel like there has some problem in add_conservative in gc.rs. Do you have this problem?

Unfortunately, I will not have access to PC for one or two days so Idk where the problem is. I actually tested the new GC when I was merging it and hello-world was working fine. Can you please check that you run the latest dev branch GC?

jameslahm commented 3 years ago

The problem should be here. And I have added the index check. It works fine now. https://github.com/Starlight-JS/starlight/blob/df79b323af25be4132589cf16a3a6537203d9adf/crates/starlight/src/gc/space_bitmap.rs#L84-L93 EDIT: I have checked that I am on the latest dev branch

jameslahm commented 3 years ago

And I continue to look at the problem of regression testing 🤣