async/promise PoC

[andrieshiemstra]

This is more a review request than a final PR

• questions
  • [ ] for persistent roots i use a HashMap based on a generated ID, at first i thought i'd just use the inner ptr of JsObejct as ID but then it would not work when multiple jobs add a persistent root for the same object. I once implemented an AutoIdMap for use case like this but it's far from perfect. does anyone know a more std/elegant solution for things like this?
  • [x] For persistentRoots i'dd like to create a strcut which releases the root on Drop but i need a ref to the Runtime, (or at leasts it's map of roots) should i just add an Rc to the map or is there allready a way to have some sort of reference to the Runtime?
• todos
  • [ ] static Promise methods like .all
  • [ ] test cases
  • [x] if resolved or rejected with sub Promise, reject or resolve with result of sub promise
  • [x] constructor, run executor sync, in resolve run subs async

[jameslahm]

serializer seems to be broken. Promise native methods should be add in VM_NATIVE_REFERENCES. https://github.com/Starlight-JS/starlight/blob/4b49db82ee017a4ff82029a9b4a1f9a9dbc6b5ca/crates/starlight/src/jsrt.rs#L901-L913

[andrieshiemstra]

serializer seems to be broken. Promise native methods should be add in VM_NATIVE_REFERENCES.

Thanks for pointing that out! fixed

[playXE]

for persistent roots i use a HashMap based on a generated ID, at first i thought i'd just use the inner ptr of JsObejct as ID but then it would not work when multiple jobs add a persistent root for the same object.

Your persistent root can be reference counted and stored in hash map. On GC when constraint for the Runtime instance is executed you just remove all the roots that have 1 reference count left. I think you can even just use Vec there?

[playXE]

BTW maybe you can remove async from test_ignore.txt so we can see how many tests run fine and what tests might segfault?

[andrieshiemstra]

remove async from test_ignore.txt

i'l work on this seperately > #66

[andrieshiemstra]

fairly happy about this for now, since i'm on vacation the next 3 weeks i'd like to merge this now, there are some followup tickets i'll create to get Promises realy fully functional

• [ ] static .allSettled / .any
• [ ] validate inner workings and create test cases
• [ ] update PersistentRooted workings (us Vec instead of map)