playXE
commented
3 years ago We should slowly start remove uses of letroot!. Rules for removing it are simple:
- if letroot is used to root JsValue then remove its usage
- if letroot is used to root GcPointer or WeakRef or any struct that is allocated on stack and contains GC pointer remove its usage
- if letroot is used to root Vec,Box or other non GC allocated type that might point to GC objects do not remove letroot
Since GC now can find pointers to the heap on the stack shadow stack is almost useless now.
Depends on #73 so we can find JS values on the stack.