search

Starlight-JS / starlight

JS engine in Rust
https://teletype.in/@starlight-js
Mozilla Public License 2.0
511 stars 9 forks source link

Update test262 results in pull request comments #81

Closed jameslahm closed 3 years ago

playXE commented 3 years ago

Is it ready to merge?

jameslahm commented 3 years ago

No, there exists some problem with caching I think. Now the building is too slow. And I also need to check the push test262 repo. I will convert it to draft first.

jameslahm commented 3 years ago

By the way, I want to ask if you receive my email 🤣. And I probably need to add a secret in actions to push to the test262 results repo.

playXE commented 3 years ago

Oh, sorry! I haven't checked e-mail for a while! I'll give you collabarot access but first I have to figure out how :D

playXE commented 3 years ago

@jameslahm I changed permission for organization members to "Write" so you should be able to push to Starlight-JS repos

github-actions[bot] commented 3 years ago

Test262 conformance changes:

Test result master count PR count difference
Total 78,695 78,695 0
Passed 13,705 13,709 +4
Ignored 24,241 24,241 0
Failed 40,749 40,745 -4
Panics 1,253 1,251 -2
Conformance 17.42 17.42 +0.01%
Base Failed But New Passed./test262/test/built-ins/Object/keys/15.2.3.14-4-1.js ./test262/test/built-ins/Object/keys/15.2.3.14-2-8.js
New Failed But Base Passed
jameslahm commented 3 years ago

@playXE It works now! I think we could merge this first. I'll add windows runner tomorrow. WDYT?