search

Starlight-JS / starlight

JS engine in Rust
https://teletype.in/@starlight-js
Mozilla Public License 2.0
509 stars 9 forks source link

chore: add windows runner in actions #83

Closed jameslahm closed 3 years ago

jameslahm commented 3 years ago

Embarrassed, I don't have a windows machine.

jameslahm commented 3 years ago

@playXE Do you have any idea?

jameslahm commented 3 years ago

I guess I'll try to use rust-lldb to debug windows in actions. 🤣

playXE commented 3 years ago

@playXE Do you have any idea?

nope. I do not have windows machine :(

playXE commented 3 years ago

@jameslahm I guess this error might be caused by that I enabled weak refs in ICs, maybe try reverting this change and build again? 🤔

jameslahm commented 3 years ago

I'll rebase later

github-actions[bot] commented 3 years ago

Test262 conformance changes:

Test result Dev count PR count Difference
Total 79,437 79,437 0
Passed 13,719 13,720 +1
Ignored 24,388 24,388 0
Failed 39,993 39,992 -1
Panics 1,337 1,337 0
Conformance 17.27 17.27 +0.00%
Base Failed But New Passed ``` 1. [non-strict] test262/test/built-ins/Object/keys/15.2.3.14-3-1.js 2. [strict] test262/test/built-ins/Object/keys/15.2.3.14-3-1.js ```
New Failed But Base Passed ``` 1. [strict] test262/test/built-ins/Object/keys/15.2.3.14-2-8.js ```