Starlight-JS / starlight

JS engine in Rust
https://teletype.in/@starlight-js
Mozilla Public License 2.0
514 stars 9 forks source link

macOS build segfaults #87

Closed playXE closed 3 years ago

playXE commented 3 years ago

Something is going wrong on macOS. I do not have macOS machine so I can't debug it

jameslahm commented 3 years ago

I'll work on it.

playXE commented 3 years ago

@jameslahm looks like 43d3084d8b711b3a637ebad005e207981bbbbb79 solved it but solution is really stupid. approximate_stack_pointer has the same code as I put in collect_internal and I have zero idea why it does work now

jameslahm commented 3 years ago

Sorry, I am able to use a macOS machine since tomorrow. I'll try to look into it tomorrow.