search

StarlingGraphics / Starling-Extension-Graphics

flash.display.Graphics style extension for the Starling Flash GPU rendering framework
https://github.com/StarlingGraphics/Starling-Extension-Graphics/wiki
MIT License
285 stars 88 forks source link

Bounds of a Shape null/infinity when width or height are minus values #50

Closed robsilv closed 11 years ago

robsilv commented 11 years ago

See the BoundsTest. When either the width or height value of the bounds becomes negative, the x, y, w & h values of Shape.bounds become null or infinite values.

IonSwitz commented 11 years ago

I have a fix... Trying to wrestle with Git, as usual, though.

IonSwitz commented 11 years ago

@robsilv , I have sent in a fix on my IonSwitz branch. Naturally, my typo fingers called it "Update to fix betBounds bug". Coz, you know, "betBounds" is a valid word. ;)

robsilv commented 11 years ago

Cool! Please feel free to create a pull request and merge it into the main project if it fixes the problem. I might not be able to review any commits now for a few months, as we leave on a long awaited trip next week and have lots of last minute things to sort out..! :-S

IonSwitz commented 11 years ago

I THINK I managed to create the Pull Request AND Merge it to the StarlingGraphics branch without anything breaking. Thanks for your patience with me :)

robsilv commented 11 years ago

Excellent! Looks good to me, I haven't played with the code yet, but glad you're getting the hang of Git! :-)

IonSwitz commented 11 years ago

Closing this.