search

StarlingGraphics / Starling-Extension-Graphics

flash.display.Graphics style extension for the Starling Flash GPU rendering framework
https://github.com/StarlingGraphics/Starling-Extension-Graphics/wiki
MIT License
285 stars 88 forks source link

Stroke fixUpPolyLine bug #51

Closed hooh closed 10 years ago

hooh commented 11 years ago

This line idx would be a big int while vertices.length==0 var idx:uint = vertices.length - 1; while ( idx > 0 && vertices[idx].degenerate > 0 )

jarrodmoldrich commented 11 years ago

My bad. There should be a zero-length early-out either in buildGeometry or in fixUpPolyLine. You can fix it and make a pull request, otherwise I'll fix it on my own time, when I find some....

On 16 August 2013 12:17, hooh notifications@github.com wrote:

This line idx would be a big int while vertices.length==0 var idx:uint = vertices.length - 1; while ( idx > 0 && vertices[idx].degenerate > 0 )

— Reply to this email directly or view it on GitHubhttps://github.com/StarlingGraphics/Starling-Extension-Graphics/issues/51 .

Jarrod Moldrich - Mobile Apps Developer mob: +61401686802

IonSwitz commented 10 years ago

'This has been changed and is part of the new SWC, the idx variable has been changed to a "int". Somehow, I doubt anyone will be creating 2 billion vertices in one stroke.