StarlingUAS / ProjectStarling

BRL Flight Arena Infrastructure 2.0
Other
16 stars 3 forks source link

Fix PX4 SITL Dockerfile #157

Closed rob-clarke closed 2 years ago

rob-clarke commented 2 years ago

In upgrading to the latest PX4 version at some point, the non network=host SITL got broken. The sed line here no longer actually edits the file as it is missing a -f before -m onboard. This means that the MAVLink output is only ever sent to localhost

mhl787156 commented 2 years ago

Ah I think I have fixed that in the latest dev branch as I ran into that issue: https://github.com/StarlingUAS/ProjectStarling/blob/dev/simulator/base/px4/sitl.Dockerfile

Could you confirm that that should work?

rob-clarke commented 2 years ago

Yeah that should work. I must have been running latest

rob-clarke commented 2 years ago

Yeah nightly looks good