search

StarlingUAS / ProjectStarling

BRL Flight Arena Infrastructure 2.0
Other
16 stars 3 forks source link

Docker-Compose with network=host to enable rviz/rqt bare metal ROS2 #97

Closed mhl787156 closed 2 years ago

mhl787156 commented 2 years ago

Currently docker-compose still runs with the default docker network stack which is separate from standard networking.

However if we want to allow use with Bare metal ROS2 (i.e. rviz and rqt) we need to test whether network=host works. This can be done via adding the below to all services. 

network_mode: host
mhl787156 commented 2 years ago

@rob-clarke Sooo... it turns out that we can't do this as network=host is not functional on docker desktop for windows or mac. The current master is broken for windows.

rob-clarke commented 2 years ago

I'd say the bare metal stuff should be Linux specific supported for now. But yes removing the setting from the compose files is needed

mhl787156 commented 2 years ago

Proposal, we have a docker-compose.linux.yaml with network_mode=host, and a 'other' package docker-compose.win.yaml with the old style.