search

Starlink / starjava

Java applications initially developed for the Starlink Project but now developed independently
Other
84 stars 23 forks source link

Missing symbols in ADQL #66

Closed olebole closed 9 hours ago

olebole commented 3 weeks ago

While trying to update the Debian packages of Starjava, In encountered a compilation error with the "vo" package; specifically missing symbols. From the log:

build:
    [mkdir] Created dir: /build/starjava-vo-0.2+2023.11.01/build/classes
    [javac] Compiling 117 source files to /build/starjava-vo-0.2+2023.11.01/buil
d/classes
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlVersion.java:39: error: cannot find symbol
    [javac]     private final ADQLParser.ADQLVersion volltVersion_;
    [javac]                             ^
    [javac]   symbol:   class ADQLVersion
    [javac]   location: class ADQLParser
[…]
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:5: error: cannot find symbol
    [javac] import adql.db.DBIdentifier;
    [javac]               ^
    [javac]   symbol:   class DBIdentifier
    [javac]   location: package adql.db
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:13: error: package adql.parser.feature does not exist
    [javac] import adql.parser.feature.FeatureSet;
    [javac]                           ^
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:14: error: package adql.parser.feature does not exist
    [javac] import adql.parser.feature.LanguageFeature;
    [javac]                           ^
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:15: error: package adql.parser.grammar does not exist
    [javac] import adql.parser.grammar.ParseException;
    [javac]                           ^
 […]

I am using the adql package from @gmantele (part of gmantele/vollt); originally the source jar file provided with version 1.5), but now updated to the lastest master [1481ccb), which worked until Topcat 4.8.7 & friends).

Are the changes required for adql somewhere available? I couldn' find them on Github.

mbtaylor commented 3 weeks ago

Hi @olebole. To support ADQL 2.1, TOPCAT v4.8-8 and later are using an adqlLib version on branch adql2.1, namely gmantele/vollt@8b88a44779 (see the history of vo/src/lib/adqlParser.jar). If and when ADQL 2.1 functionality makes it into the master branch or a public release of VOLLT, that will be updated.

olebole commented 9 hours ago

This is resolved with the adql-2.0-beta version, so I am closing.