search

Starlink / starlink

Starlink Software Collection
162 stars 53 forks source link

PHOTOM segv #25

Closed MalcolmCurrie closed 10 years ago

MalcolmCurrie commented 10 years ago

When using the GWM/SGS interface after measuring an aperture, PHOTOM crashes with a segv in aptop.f at the DAT_UNMAP (Line 680) while freeing up HDS workspace. Operating with the same parameters from GAIA there is no crash. The code probably needs valgrinding or even updated to use a modern PSX or AST approach to obtaining workspace.

Recorded here as we're too busy at present to investigate now.

pwdraper commented 10 years ago

The problem is an fixed sized array GRID(64,64) that is being overrun. AUTOPHOTOM dynamically allocates this array so doesn't have the same problem. I've increased the size to GRID(256,256) and the parameter will no longer allow SEMIM to be larger than 128.

timj commented 10 years ago

@pwdraper Which commit is this? Was it pushed? I can't find it in master.

pwdraper commented 10 years ago

@timj, @MalcolmCurrie : sorry the one I just pushed.

timj commented 10 years ago

Thanks. That was commit 14b534aa713a29b46cb9bf0ddb0b3ed5acc80368