search

Starlink / starlink

Starlink Software Collection
162 stars 53 forks source link

make world does not install all documents #4

Closed timj closed 11 years ago

timj commented 11 years ago

Even though the documents in docs/ work with bootstrap, configure and make, they are not part of make world. For example sgp38.tex is not built. Looking at the Makefile there are only entries for:

    $(MANIFESTS)/sc2 \
    $(MANIFESTS)/sc3 \
    $(MANIFESTS)/sc4 \
    $(MANIFESTS)/sc5 \
    $(MANIFESTS)/sc6 \
    $(MANIFESTS)/sc7 \
    $(MANIFESTS)/sc9 \
    $(MANIFESTS)/sc12 \
    $(MANIFESTS)/sc14 \
    $(MANIFESTS)/sc15 \
    $(MANIFESTS)/sc17 \
    $(MANIFESTS)/sc21 \
    $(MANIFESTS)/sg8 \
    $(MANIFESTS)/sg9

but Makefile.dependencies lists all the documents properly. I think that the new documents were never added to Makefile.in. I see that @pwdraper added the cookbooks and sg8 and sg9 in 2f49bb3d2e2cd48ab0d913f1a1ceb9fc518c7c89 but there was no correponding followup commit to 963e49390435e758e7794d0f424a97b9b1869b75 which was the one that added all the other documents to the dependencies file in 2008.

I'm amazed I only just noticed. It came up because I needed an online link to SGP/38.

pwdraper commented 11 years ago

I expect the reason I didn't include all the documents is that the build state of them was unknown at the time @MalcolmCurrie was still working on them. At least that's what I remember.

timj commented 11 years ago

Turns out that SUN/93 is actually written in TeX and not LaTeX so the build doesn't complete. Given that none of the documentation build targets understand TeX files and given the SUN/93 is a document explaining how TeX should be used, it's probably fine to remove it from the build. A compromise may be to adjust the make target to simply install sun93.tex in the documentation tree without attempting to build it.

timj commented 11 years ago

@MalcolmCurrie sorted this out with commit e22dc98ce9fc750c5288607a559fd1a58f8d2f46 reasoning that a document on using TeX is not useful when the standard is to use LaTeX.

MalcolmCurrie commented 11 years ago

I expect the reason I didn't include all the documents is that the build state of them was unknown at the time @MalcolmCurrie was still working on them. At least that's what I remember.

Looking back I had added many documents then in 2008 January there was a discussion ("document building") on adding these to the build instigated by @timj with most responses from @pwdraper with contributions from @MalcolmCurrie and @nxg. There was some build issue to do with

kpathsea. Looks like the ball was dropped.

Scanned by iCritical.

timj commented 11 years ago

Well, I hope everything is sorted out now. There was only that one problem and we are ignoring the XML documents.