Starlink / starlink

Starlink Software Collection
162 stars 53 forks source link

pamela polfit command not found #68

Closed htugcas closed 4 years ago

htugcas commented 4 years ago

polfit and various other commands are not found in bash (MasOS High Sierra 10.13.6) despite the following files exist.

pamela folder is under star-2018A/bin, and inside pamela there is polfit and many others.

profile file in star-2018A/etc has pamela as

#  PAMELA

if test -f ${bindir}/pamela/pamela.sh; then
   export PAMELA_DIR=${bindir}/pamela
fi

Am I missing something or is there a discrepancy?

trmrsh commented 4 years ago

Hi, yes, I think this comes down to the following lines within $STARLINK_DIR/etc/profile:

if test -f ${bindir}/pamela/pamela.sh; then pamela () { ${PAMELA_DIR}/pamela.sh; } pamelasetup () { ${PAMELA_DIR}/pamela.sh; } else

which should instead be:

if test -f ${bindir}/pamela/pamela.sh; then pamela () { . ${PAMELA_DIR}/pamela.sh; } pamelasetup () { . ${PAMELA_DIR}/pamela.sh; } else

I thought I had corrected this (post-2018A) on github but I lack the competence to be sure of this and could not see anything obvious when I ran 'git log'.

htugcas commented 4 years ago

I have read this solution and already checked it but apparently I had to ask to sort it out. Thanks a million!

timj commented 4 years ago

Looks like @grahambell fixed it in commit 6d99cbc381b9ea8d9ca8a5120a2ee87757344b1c a year ago so it looks like a 2019 release should be fine.

htugcas commented 4 years ago

I used the latest release here. If there is a new release in 2019, this page might benefit an update.

sfgraves commented 4 years ago

We (EAO) didn't do a release in 2019 -- 2018A is the most recent. We do provide nightly builds from the master branch on github though.

We're planning a release in early 2020, but I'm not sure exactly when. I'm hoping we can get some decent testing on David's changes to a C-based NDF and to support 64 bit indexing, so that might delay it a bit.