Update http-data-source.ts

StarpTech / apollo-datasource-http

Optimized JSON HTTP Data Source for Apollo Server

MIT License

73 stars 32 forks source link

Update http-data-source.ts #12

Closed nmokkenstorm closed 3 years ago

StarpTech commented 3 years ago

Hi @nmokkenstorm could you lose few words?

nmokkenstorm commented 3 years ago

Hey @StarpTech , I was looking through the request/response structure for this class because of the issue/question I posted and saw this status code logic. Considering 304 is between 200 and 399 I don't think the special case actually does anything here code wise, nor does it really add to the clarity. I made the edit in the GitHub web interface, hence the brevity, my apologies.

StarpTech commented 3 years ago

Ah, I got it. Make sense. Thank you for the PR.