search

StarpTech / apollo-datasource-http

Optimized JSON HTTP Data Source for Apollo Server
MIT License
73 stars 32 forks source link

update QuickLRU option #15

Closed canxuemianbao closed 3 years ago

canxuemianbao commented 3 years ago

image As quickLRU just mention they will set maxAge default to infinity, i think we can keep undefined acceptable

StarpTech commented 3 years ago

Hi @canxuemianbao please add a test.

canxuemianbao commented 3 years ago

@StarpTech updated

StarpTech commented 3 years ago

@canxuemianbao Please merge main in your branch.

StarpTech commented 3 years ago

@canxuemianbao it's failing on Node.js 16.

shkaper commented 3 years ago

Sorry, I wasn't sure how active this is, so I've opened #21 with a fix for the unit test. I'm preserving @canxuemianbao 's authorship on the commits there

StarpTech commented 3 years ago

This PR can be closed then?

shkaper commented 3 years ago

Yes. Please review the other one when you get a chance.

StarpTech commented 3 years ago

Will do.