update QuickLRU option (2)

StarpTech / apollo-datasource-http

Optimized JSON HTTP Data Source for Apollo Server

MIT License

73 stars 32 forks source link

update QuickLRU option (2) #21

Closed shkaper closed 2 years ago

shkaper commented 2 years ago

Following up on #15, I've fixed the flaking test there. I think sinonjs FakeTimer is a more robust solution for a test where timeouts are involved.

Closes #14

shkaper commented 2 years ago

Hey @StarpTech, have you got the chance to review this yet?

thiagomini commented 2 years ago

Hi @shkaper and @StarpTech , we (The company I'm currently working) are in need of this feature as well. Can you merge this and update the package?

StarpTech commented 2 years ago

Hi @thiagomini, the PR is reviewed, but the original author isn't responding. In the future, I recommend creating a separate PR with the changes. I'll handle it for now.