Proposal of tweaks around global and local cache configuration

StarpTech / apollo-datasource-http

Optimized JSON HTTP Data Source for Apollo Server

MIT License

73 stars 32 forks source link

Proposal of tweaks around global and local cache configuration #45

Open kdybicz opened 2 years ago

kdybicz commented 2 years ago

Making sure global cache configuration is taken into consideration for all datasource methods
Making sure method-specific cache configuration is overriding global configuration, if present
Adding related tests
Adding VSC configuration folder to .gitignore

kdybicz commented 2 years ago

@StarpTech I'm happy to talk through the changes I've made and the motivation, I also have following changes queued up, ie. for optional maxTtlIfError and I'm thinking on improving performance and bandwidth used while caching with maxTtlIfError

StarpTech commented 2 years ago

Hi @kdybicz sorry for the late response. Your change will give request options precedence over global defaults. This is natural and the current behavior was more of a bug.