search

StarrFox / wizwalker

Wizard101 scripting api
https://starrfox.github.io/wizwalker
GNU General Public License v3.0
37 stars 30 forks source link

Fixed tempest not being picked up by get_damaging_aoes() #50

Closed 7e11 closed 2 years ago

7e11 commented 2 years ago

Rev2

Changed to a substring match, verified in game with tempest.

Rev1

Was trying out AoeHandler and noticed that tempest wasn't being picked up as a damaging AOE. As you noted in the discord, tempest has the effect type VariableSpellEffect because it's an X cost spell.

I added that type to the effect_types checked by the handler and everything worked alright. I'm not sure why VariableSpellEffect wasn't checked as I'm sure people realized tempest wasn't working. If there's a reason (like maybe it causes issues with other spells), I'll close the request.

Also added some awaits for async calls that weren't being awaited for.

StarrFox commented 2 years ago

thanks for contributing to wizwalker!