search

StarryPy / StarryPy3k

StarryPy on Python3k
Other
53 stars 35 forks source link

Feature/docker config #133

Closed evonzee closed 5 years ago

evonzee commented 6 years ago

Hi folks,

I added a baseline dockerfile so I can run this project in a container. Thought it might be useful for you as well.

Currently I am not doing anything fancy with volumes for the config/player db, though I think that would be valuable.

I expect to have other PRs that will include these changes; let me know if you don't want these and I'll produce future PRs without them.

kharidiron commented 6 years ago

I like the idea of having a docker option as well, though I'd like to see it a bit more fleshed out/fully tested before we merge it in. Once you're relatively certain you don't need to make many further changes to the files, I'll be happy to merge it.

As another point to consider, we will eventually be retiring this build, as we are in the process of doing a from-scratch rebuild of the code base, keyed to Python 3.7 or later, and getting rid of some really bad design decisions. It isn't ready for production use yet, but it is where we are putting our efforts for future features.

evonzee commented 6 years ago

Interesting! I don't see a likely branch in the upstream repo; Is that rebuild hosted in a different repository? I'd be happy to build against that instead/as well.

I'll update this PR with:

I'll leave the (presumed) dockerhub setup to you as the project owner.

rubellyte commented 6 years ago

Development is indeed occurring in another repo, though all of the work is currently in forks right now, so there isn't terribly much to see there... Unfortunately we're still (re)building the base, so there isn't especially much to be done now, but your contributions would definitely be appreciated later. I'll sit down later today and see if I can get a reasonable bit of the framework done...

DiNitride commented 6 years ago

Is there any way that people (Me) that have been interested in the project get involved with the rebuilding and design, one of the main reasons I never got into anything on my fork is due to the project not having much documentation.

I've also got a few questions/suggestions about the structure of the project

On Sun, 21 Oct 2018, 15:32 medeor413, notifications@github.com wrote:

Development is indeed occurring in another repo https://github.com/StarryPy/Project-Apophis, though all of the work is currently in forks right now, so there isn't terribly much to see there... Unfortunately we're still (re)building the base, so there isn't especially much to be done now, but your contributions would definitely be appreciated later. I'll sit down later today and see if I can get a reasonable bit of the framework done...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/StarryPy/StarryPy3k/pull/133#issuecomment-431673820, or mute the thread https://github.com/notifications/unsubscribe-auth/AQznLzLbT64XFmkgqva5o1KnFb6ByVU1ks5unIVsgaJpZM4XsgP9 .

evonzee commented 5 years ago

Hi folks,

I think this branch is pretty stable at this point. We've got a (very lightly traffic'ed) test server that's been running it for a week or two, and I've been switching images using the volume support with no data loss thus far. Any thoughts on next steps/review? I've got a bunch of other feature branches waiting in the wings. :)