search

Start9Labs / bitcoind-startos

wrapper for building bitcoind.s9pk
Other
12 stars 18 forks source link

[feat]: `mempoolfullrbf=1` by default #142

Closed petertodd closed 5 months ago

petertodd commented 5 months ago

Prerequisites

Describe the Feature Request

Since about 90%+ of hashpower is mining full-rbf, it makes sense to accept and relay those replacements.

Describe the Use Case

Failing to accept and relay full-RBF replacements when almost all hash power accepts them decreases the accuracy of mempool fee estimation, and prevents users from learning about relevant transactions that are likely to get mined. This is particularly notable for users who are running block explorers on their Start 9 devices; why block explorer sites like https://mempool.space and https://blockstream.info have supported full-RBF for quite some time now.

Describe Preferred Solution

Just set mempoolfullrbf=1 by default; the configuration tool can continue to allow it to be disabled if desired. Bitcoin Core doesn't seem interested in doing this by default — likely politics around how controversial it has been. But there's no reason why we should not do the right thing for users.

Describe Alternatives

No response

Anything else?

No response

kn0wmad commented 5 months ago

As you noticed, we have generally stuck to Core defaults in an attempt to remain neutral. However, I'm sure this is worth a discussion.

remcoros commented 5 months ago

Contrary to my earlier statements (in another PR) about sticking with Core defaults. I think this one makes a lot of sense for (non-technical) users of 'full node providers' like StartOS and Umbrel.

Users of node distributions like this, do not normally follow the Bitcoin Core development, announcements and/or forums and completely rely on 'sane' defaults from these node providers.

Since it seems the network and users (not the core devs) have reached consensus about enabling mempoolfullrbf, and it improves end-user experience (fee estimation), this change makes sense to me.

Ack

k0gen commented 5 months ago

v26.1.0 will have mempoolfullrbf=1 as default

petertodd commented 5 months ago

Thanks guys! Great to see full-rbf getting deployed more widely!

On April 11, 2024 1:58:09 PM EDT, Dominion5254 @.***> wrote:

Closed #142 as completed via #143.