search

Start9Labs / bitcoind-startos

wrapper for building bitcoind.s9pk
Other
14 stars 20 forks source link

[feat]: Allow user to specify port when manually adding peers #53

Closed chrisguida closed 2 years ago

chrisguida commented 2 years ago

The need for this was generated in btc-rpc-proxy. Will be fixed on the proxy side, but should also be fixed on the bitcoind side, since the p2p interface isn't necessarily always on port 8333.

chrisguida commented 2 years ago

Apparently bitcoind doesn't like tor peers with ports. Not sure why.

Bitcoind appears to support ports for manually-added clearnet peers.

But when I put a port into the config for an onion peer

## PEERS
listen=1
bind=0.0.0.0:8333
connect=<scrubbed-tor-public-key>.onion:8333

I get errors:

2022-03-17T00:20:29.061957Z 2022-03-17T00:20:29Z Socks5() connect to <scrubbed-tor-public-key>.onion:8333 failed: general failure
2022-03-17T00:20:41.947980Z 2022-03-17T00:20:41Z Socks5() connect to <scrubbed-tor-public-key>.onion:8333 failed: general failure
2022-03-17T00:20:51.550454Z 2022-03-17T00:20:51Z Socks5() connect to <scrubbed-tor-public-key>.onion:8333 failed: general failure
2022-03-17T00:21:01.246627Z 2022-03-17T00:21:01Z Socks5() connect to <scrubbed-tor-public-key>.onion:8333 failed: general failure

Abandoning this ticket and fixing solely in proxy.

chrisguida commented 2 years ago

The above errors were due to my archival node being unavailable over tor. System restart fixed. Not sure why. Reopened.

chrisguida commented 2 years ago

Blocked by https://github.com/Start9Labs/embassy-os/issues/1347