search

Start9Labs / bitcoind-startos

wrapper for building bitcoind.s9pk
Other
14 stars 20 forks source link

remove warning about abusing your node by increasing threads #80

Closed BitcoinMechanic closed 2 years ago

kn0wmad commented 2 years ago

This was available for testing in its final form for the last week and the RPC changes were made a month ago. Please try to get copy changes in before release tags are being cut in the future

chrisguida commented 2 years ago

Why was this closed? We can still merge this and get it in next release...

kn0wmad commented 2 years ago

I changed the sentence in question already

chrisguida commented 2 years ago

Are you referring to this commit? https://github.com/Start9Labs/bitcoind-wrapper/commit/9153b47910768b88f924259eed172a413bbe32a4

Looks like that commit happened after you commented yesterday, so you actually hadn't made the change yet.

A PR should never be closed because it was submitted too late in a release cycle. If there is a conflicting change, please say so, and link to the conflicting change.

kn0wmad commented 2 years ago

I don't know where you see the date, but the commit was before my comment. I wouldn't say something was done if it wasn't. I closed only because the change had already been made.

chrisguida commented 2 years ago

Ok, just be sure to link to the conflicting change next time