search

Start9Labs / cryptpad-startos

Other
4 stars 1 forks source link

[feat]: The "Launch UI" button ought to launch either the .local or .onion depending on config #8

Open Rearden21M opened 2 years ago

Rearden21M commented 2 years ago

Right now, the Launch UI will launch the service as .local if you are on your Embassy via LAN, and as .onion if you are connected via Tor.

When you are connected on your Embassy via LAN and change the config settings to use Tor instead of LAN, one would naturally expect the "Launch UI" button to take you to the .onion address regardless of whether you are on your Embassy via LAN or Tor, since you told the service that you want to use it via Tor.

In other words, the "Launch UI" ought to launch either the .local or .onion address depending on what is selected in the config.

Related issue: https://github.com/Start9Labs/embassy-os/issues/1568

chrisguida commented 2 years ago

Thanks for the report! We should probably just have the service connect to both Tor and LAN, not sure if it'll be worth it for beta though.

chrisguida commented 2 years ago

Blocked by https://github.com/Start9Labs/embassy-os/issues/1568

chrisguida commented 2 years ago

On second thought, this is probably better solved by whenever we allow tor and clearnet simultaneously. I don't think dynamically switching the launch url is likely ever to be implemented upstream.