search

StartBootstrap / startbootstrap-clean-blog-jekyll

A Jekyll version of the Clean Blog theme by Start Bootstrap
https://startbootstrap.com/themes/clean-blog-jekyll/
MIT License
2.09k stars 2.68k forks source link

`About` and `Contact` are HTML files, not directories. #326

Open jessp01 opened 1 year ago

f-lalonde commented 1 year ago

Adding the .html is already taken care of by the scripts. This would either cause a problem or do nothing, in the best cases. This PR should be closed.

jessp01 commented 1 year ago

@f-lalonde - can you please be more specific with regards to the script you are referring to? Maybe I've missed something but in my case, this resulted in a broken link in _site/*html.

f-lalonde commented 1 year ago

I was attempting to find in the files where this is happening, but you're right in that this is not part of the code : there is not "permalink : pretty" or anything similar in the code.

However, what I found out, is that pages hosted on GitHub Pages makes that happen for you : https://stackoverflow.com/questions/21244910/remove-html-extension-from-github-pages

Of course, if you are hosting your page elsewhere, it might not work. Hence, I rescind my previous comment : changing it does not seem to cause adverse problem, and may make the theme more universally applicable.