search

StartBootstrap / startbootstrap-clean-blog

A clean Bootstrap blog theme created by Start Bootstrap
https://startbootstrap.com/theme/clean-blog/
MIT License
1.79k stars 1.84k forks source link

Yarn 2 PnP support #130

Closed alexkuc closed 3 years ago

alexkuc commented 3 years ago

Great template! Works out-of-the-box and everything is awesome!

Though it seems this template is not compatible with Yarn 2 PnP.

I have updated gulpfile.js to provide support for both, Yarn 2 and Yarn 1 (classic).

I have also updated .gitignore to exclude Yarn 2 PnP cache but if this is inappropriate I can remove it.

Let me know what you think! 😺

alexkuc commented 3 years ago

My only concern is whether https://github.com/StartBootstrap/startbootstrap-clean-blog/blob/fd4997c6ee12042c68532a6455439e7b348a7fe7/gulpfile.js#L77 is affected (sass).

Importing works fine, as-in, the final .css is not empty and contains the expected selectors.

alexkuc commented 3 years ago

@merceyz if this looks good and no further editing is required, I can squash commits into one (I did not re-write existing commits to preserve your comments for the current PR)

merceyz commented 3 years ago

Looks good :+1:

alexkuc commented 3 years ago

I'll squash the commits so you can merge the PR

alexkuc commented 3 years ago

Commits squashed into one, you can merge

merceyz commented 3 years ago

I have no power here

alexkuc commented 3 years ago

Oh, right. We need one of the contributors to review.

davidtmiller commented 3 years ago

Unfortunately we dropped gulp as a dependency and moved to raw scripts so this change will not be added in.