search

StartBootstrap / startbootstrap-sb-admin-2

A free, open source, Bootstrap admin theme created by Start Bootstrap
https://startbootstrap.com/themes/sb-admin-2/
MIT License
9.76k stars 5.72k forks source link

Manage dependencies with Bower #11

Closed rodrigoroma closed 9 years ago

rodrigoroma commented 9 years ago

It would be great if it uses Bower to control its dependencies so I can keep everything updated without the need of a new version of SB Admin just to update the Font-Awesome or Bootstrap library, for instance.

davidtmiller commented 9 years ago

I am working on creating Bower configurations for some of the more advanced themes on Start Bootstrap.

Possible Bower Components:

rodrigoroma commented 9 years ago

Great! I think this will also make your work easier once you will not have to worry about the components' version.

This theme is great!

ghost commented 9 years ago

+1 for bower support.

encodiaweb commented 9 years ago

+1 for bower support too :-)

challgren commented 9 years ago

+1 seems like a no brainer

davidtmiller commented 9 years ago

I'll put this at the top of the list of things to do then. Thanks everyone for the feedback!

challgren commented 9 years ago

If you like I can share my bower config that I modeled off SB-admin. Ideally we'd want to put the js in a dist folder. I'll propose a pull request with how I have mine setup.

davidtmiller commented 9 years ago

That works for me. Thanks @challgren for all of the edits, bug fixes, and enhancements as well. I merged everything and I'll draft up a new release in a moment so everything is implemented. Thanks so much for these contributions!

challgren commented 9 years ago

No problem I love your theme and I suck at HTML and CSS design so you helped me out a ton! Once we get this converted over to bower developers like me can just require your project and get all the sb-admin.js and sb-admin.css and not have to manually copy stuff over, it's a pretty slick system. I haven't even used it up until 5 days ago and now I'm hooked.

challgren commented 9 years ago

@davidtmiller one issue I do forsee is issues with github pages (since bower doesn't run on github) but maybe just using the CDN urls would work.

davidtmiller commented 9 years ago

I want to avoid using CDN's just to keep the baseline theme as simple as possible. That is why a Bower configuration wasn't added in the first place as well. I will have to think through this one. If you have suggestions I am open to them as well! I might have a Bower version as an alternate version of the theme, or I might try to figure out a way to make the Bower configuration files optional, so a user can delete them and just be left with the HTML/CSS/JS.

challgren commented 9 years ago

Well we can commit the files pulled with bower and then just set them to ignore in the bower.json file. I'll do that pull request in a few minutes

challgren commented 9 years ago

I just finished the pull request. The example can be found at http://challgren.github.io/startbootstrap-sb-admin-2/examples/index.html it you want to look at it before you pull

challgren commented 9 years ago

You can also test it with 

bower install git://github.com/challgren/startbootstrap-sb-admin-2.git#gh-pages
challgren commented 9 years ago

Here's what the package looks like when installed via bower

bower dir

challgren commented 9 years ago

Also where did you get timeline.css from?

davidtmiller commented 9 years ago

It's a custom thing from Bootsnipp so it's not technically a plugin.

challgren commented 9 years ago

Ok yeah thats the one I found. If you have any suggestions on the dir structure let me know. Its designed the way I think it should

davidtmiller commented 9 years ago

I am going to merge and then see if I need to change anything. Thanks a ton for setting all of this up!

davidtmiller commented 9 years ago

What do you think about renaming the 'examples' directory into 'pages'?

davidtmiller commented 9 years ago

Rather, what is the logic behind putting all of the HTML into the 'examples' directory? I would rather keep them in the root directory for URL purposes. Is there a reason they are isolated like that?

challgren commented 9 years ago

It makes it easier to see and setup quickly. Not having 13 html files 1 css and 3 js files in the root directory. And most of the plugins you are using follow that same directory structure

davidtmiller commented 9 years ago

Sounds good to me. And it's nothing a few redirects can't handle. I'm going to make a new release and let the world know. Do you have a Twitter handle I can give a shout out to for all of the help?

challgren commented 9 years ago

Ok, I'll register it with bower as sb-admin2 I do have twitter but its private but its https://www.twitter.com/challgren

davidtmiller commented 9 years ago

sb-admin-2 would be the correct title, I can take care of registering it as well.

challgren commented 9 years ago

Ohh ok go ahead I'll add it to my project as soon as its up!

challgren commented 9 years ago

Looks like someone registered flatly-sb-admin

davidtmiller commented 9 years ago

The official Start Bootstrap stuff will always be prefaced by startbootstrap- just like the repos on GitHub. It's registered now at startbootstrap-sb-admin-2.

challgren commented 9 years ago

Sweet! Also what do you think about fixing #12 with the provided code?

davidtmiller commented 9 years ago

I plan on it. Anything to make it better. I am no JavaScript wiz. HTML/CSS are more my thing!

davidtmiller commented 9 years ago

Thanks again for all the help @challgren. Everything should be updated to v1.0.3 and the master branch and gh-pages branch are synced up. Thanks again, closing this one for now!