search

StartPolymer / polymer-starter-kit-plus-old

A starting point for building Single-Page Applications with Polymer 1.x
Other
78 stars 26 forks source link

Icons defined in iron-icons/iron-icons.html cannot be used due to iconset name collision #34

Closed Artanis closed 8 years ago

Artanis commented 8 years ago

Both iron-icons/iron-icons.html and app/themes/default-theme/icons.html define an icon set icons.

default-theme usually loads last and ends up clobbering iron-icons.

The iconset defined in default-theme should be renamed, and current unprefixed icon references should be prefixed with that name.

JosefJezek commented 8 years ago

Yes, default theme using custom icons. iron-icons element is large file. You can copy svg icons from iron-icons to icons.html

Check out this video... https://www.youtube.com/watch?v=tjmRUgUca1g

JosefJezek commented 8 years ago

https://github.com/StartPolymer/polymer-starter-kit-plus/commit/50bb48e90e58fd0dcb447ab6517c0b5e4c9107ec

Artanis commented 8 years ago

Huh. Dunno how I missed that Polycasts episode. That does make a great deal of sense... however, I still feel that it's not ideal to clobber the icons set.

I also don't think manually maintaining copies of all the icons you use is a good idea, but the limits of this optimization are better discussed at iron-icons (PolymerElements/iron-icons#19, for example).

JosefJezek commented 8 years ago

We need custom pack of icons for high performance. ;-)