search

Starwaster / DeadlyReentry

Heat and force damage for KSP
Other
31 stars 19 forks source link

Change heat values for TACLS items #30

Closed clintonmead closed 7 years ago

clintonmead commented 7 years ago

I know TACLS isn't your mod, and you can't be expected to change the heat values for every mod, but TACLS is often used with Deadly Reentry, and it's storage units have ridiculous maximum heat values of 3200K.

I could ask TACLS to change it but they probably wouldn't be consistent with deadly reentry's settings, so I thought it would be best to ask here.

They shouldn't be higher than 1000K/1000K as is the case with other deadly entry parts like decouplers. Otherwise they can be used as defacto heat shields which is a bit silly.

Just something for you to perhaps put in the 1.2 version. If you're happy with this change but haven't got the time to make it, just tell me and I'll make a pull request. I haven't done modding before but I'm sure I can work it out.

Starwaster commented 7 years ago

Deadly Reentry actively goes through every part in the database during start up and reduces the max temperatures in accordance with a setting called (appropriately enough) ridiculousMaxTemp. If a part's max temp values are above that number then they are cut in half. If they still exceed the ridiculousMaxTemp then it is capped at ridiculousMaxTemp (set at 1523 K)

Instead of looking at the config values, check it out in-game. It should be significantly lower than what is in those configs.

UNLESS the other modder has opted out, which is allowed for by adding leaveTemp = true. If TACLS has done that then Deadly Reentry will skip that part and leave its maxTemp values alone, and I won't interfere, no matter what my own opinion is on the matter.

clintonmead commented 7 years ago

Ah, I was checking it out ingame but I was using the 1.1.3 version with 1.2 so I suspect that part is broken.

I'll just set rediculousMaxTemp to 1000K when the 1.2 version comes out. So closing this ticket.