search

Starwaster / DeadlyReentry

Heat and force damage for KSP
Other
31 stars 19 forks source link

NRE fixes and chute warning toggle. #5

Closed taniwha closed 9 years ago

taniwha commented 9 years ago

This fixes some holes that produce NREs and also provides a toggle for the parachute warning.

The warning is a nice feature for newbies, but there are a great many of us that really do not need it, so being able to turn it off is very nice. Note that if the option is turned off while the message is displayed, it will take a second (longer if frame rate is poor) to disappear.

Starwaster commented 9 years ago

Looks good but the way you've got that toggle set up, it's going to be a per-difficulty setting like most of the others. I'd either handle it under default only or maybe use the DRE scenario module to store the setting.

taniwha commented 9 years ago

Oh, that was not intentional. I'll poke at it some more.

Starwaster commented 9 years ago

Not home right now but when I get back I can switch it over. Or if you want to do it yourself that's cool too.

taniwha commented 9 years ago

Yeah, first time through, the settings save code didn't make much sense.

Starwaster commented 9 years ago

Ugh, crap I just realized my advice was bad and that scenario was the wrong answer too. Because then that makes it 'per save game'... though it probably is better than doing it per save game. I'll go ahead and merge it and figure out if there's a better way. Maybe handle it the way I handled ridiculousMaxTemp, which only looks at the Default settings when it grabs that field.

taniwha commented 9 years ago

Cool, thanks. I think per-save will not be a problem for anybody. Those that need the warning will get it, those that don't will just turn it off either when they start a new save, or after the first message. And for those in between, it will serve as a reminder :).