Starwaster / DeadlyReentry

Heat and force damage for KSP
Other
31 stars 19 forks source link

Damage internal flux fixes #56

Closed NathanKell closed 3 years ago

NathanKell commented 3 years ago

Three fixes to the extra flux applied when a part is damaged:

Starwaster commented 3 years ago

I have a small concern about finalCoeff in that it has heatConvectiveConstant which I don't think should affect what flux leaks into the interior through the hole burned into the ship.

But not too many people use it and it's probably not that big a deal...

NathanKell commented 3 years ago

Yeah, it's not unreasonable to divide by it and then multiply by the default value here (well, check for it != 0 to avoid a divzero).

NathanKell commented 3 years ago

Heh, that said this code is no worse in that regard than the original, no? Since the original used the actual flux, which is post multiplication of heatConvectiveConstant anyway.