StatCan / aaw-argoflow-azure

Kubeflow deployment powered by ArgoCD
2 stars 2 forks source link

Argoflow manifest verify namespaces #20

Closed wg102 closed 3 years ago

wg102 commented 3 years ago

Compare our manifest and kubeflow's, with careful checking for any customization. Update the argoflow-azure applications in distribution Test Duplicate the changes in the template.


Adding details to this issue. There is a folder named namespaces under https://github.com/StatCan/aaw-kubeflow-manifest/tree/master/kustomize/namespaces We need to verify if this is still valid, and if we should use this patch, no patch, or a new version of a patch.

Another thing that might be wise to test are the default namespaces created.

Jose-Matsuda commented 3 years ago

Ours https://github.com/StatCan/aaw-kubeflow-manifest/tree/master/kustomize/namespaces

1.2 https://github.com/kubeflow/manifests/tree/v1.2-branch/namespaces/base

1.3 https://github.com/kubeflow/manifests/blob/v1.3-branch/common/kubeflow-namespace/base/namespace.yaml

Jose-Matsuda commented 3 years ago

Both namespace and cert manager seem to be deployed and healthy. Will just apply the patch and check if it works

Jose-Matsuda commented 3 years ago

In the patch it removes the control-plane label and I have added the label katib-metricscollector-injection to this list of labels to remove as I do not know what it is for.

After running and deploying it seems to be good

Jose-Matsuda commented 3 years ago

Closing (as completed)