Mistake on my part - turns out there are (at least?) two different core Facets products. Our notebooks have Facets Dive installed and I was thinking we should have a demo for that. But I didn't realize there was also Facets Overview, which you've installed and added a demo for. Sorry!
So to bring things together, I suggest:
Add a text explanation at the top of this demo saying what the product is, why you'd use it, etc. Something that lets the reader know what they're about to read (like here or here). Doesn't have to be long, but at least a few sentences so they know if it is interesting to them
Break the demo into two sections: facets-dive and facets-overview.
Cover dive first because it should be fully installed already (you shouldn't have to pip install anything)
Follow with the overview demo you have next. Add a note about how the facets-overview is not installed by default but that we can install it.
For the demo, there's a fair amount of duplicate imports (ex: pandas is imported in three cells, one of which under a non-conventional import pandas as pdl name) so cleaning those up would be helpful. Also for the HTML_TEMPLATE parts I think it is non-obvious what those do, so if you can add a little explanation (even something like "this is how we show facets graphics in a notebook, see (link) for more info").
Mistake on my part - turns out there are (at least?) two different core Facets products. Our notebooks have Facets Dive installed and I was thinking we should have a demo for that. But I didn't realize there was also Facets Overview, which you've installed and added a demo for. Sorry!
So to bring things together, I suggest:
facets-dive
andfacets-overview
.dive
first because it should be fully installed already (you shouldn't have topip install
anything)overview
demo you have next. Add a note about how thefacets-overview
is not installed by default but that we can install it.For the demo, there's a fair amount of duplicate imports (ex: pandas is imported in three cells, one of which under a non-conventional
import pandas as pdl
name) so cleaning those up would be helpful. Also for theHTML_TEMPLATE
parts I think it is non-obvious what those do, so if you can add a little explanation (even something like "this is how we show facets graphics in a notebook, see (link) for more info").