search

StatCan / aaw-contrib-jupyter-notebooks

Jupyter Notebooks to be used with Advanced Analytics Workspace platform
Other
10 stars 13 forks source link

fix: refactored notebooks #42

Closed rohank07 closed 3 years ago

rohank07 commented 3 years ago

Close #38 Refactored notebooks

ca-scribner commented 3 years ago

I'll tackle this more in the morning, but looking good so far!

ca-scribner commented 3 years ago

Minor note - while working on this if you know anyone else has pulled/used it before, be really careful with the force-push. It'll break anyone else's history/prevent them from doing git pull on the branch/might make it hard for them to merge their changes in. If you're looking for a clean git history, there's no harm in doing the squash and force push at the end :)

Also, there's still cases where a force push is a good idea. Just pointing it out in case you didn't realize!