search

StatCan / aaw-kubeflow-containers

Containers built to be used with Kubeflow for Data Science
Other
24 stars 21 forks source link

Fix aaw-kubeflow-containers makefile and make instructions #578

Open bryanpaget opened 7 months ago

bryanpaget commented 7 months ago

I updated the github actions a while ago as part of tickets:

This has made our Makefile conformant to Github's standards but presents a problem when building images locally.

(base) pagetbr@l-pagetbr-2:~/aaw-kubeflow-containers$ make build/rstudio
# End repo with exactly one trailing slash, unless it is empty
REPO=$(echo "k8scc01covidacr.azurecr.io" | sed 's:/*$:/:' | sed 's:^\s*/*\s*$::') &&\
IMAGE_NAME="${REPO}rstudio:master" && \
DOCKER_BUILDKIT=0 docker build  --rm --force-rm -t $IMAGE_NAME ./output/rstudio && \
echo -n "Built image $IMAGE_NAME of size: " && \
docker images $IMAGE_NAME --format "{{.Size}}" && \
echo "full_image_name=$IMAGE_NAME" >>  && \
echo "image_tag=master" >>  && \
echo "image_repo=${REPO}" >> 
/bin/sh: 6: Syntax error: "&&" unexpected
make: *** [Makefile:206: build/rstudio] Error 2
(base) pagetbr@l-pagetbr-2:~/aaw-kubeflow-containers$