StatCan / aaw-kubeflow-containers

Containers built to be used with Kubeflow for Data Science
Other
24 stars 21 forks source link

add jupyterlab python package #622

Closed bryanpaget closed 2 months ago

bryanpaget commented 4 months ago

Add jupyterlab python package.

Jose-Matsuda commented 4 months ago

Just adding context; this issue broke both branches; related commit to 2.0 branch is: https://github.com/StatCan/aaw-kubeflow-containers/commit/9b5fcc27d2ea3adbfa3f5339d63f58337f3ed687

image

Souheil-Yazji commented 4 months ago

I thought this package was in the base images we use? see https://github.com/jupyter/docker-stacks/blob/main/images/base-notebook/Dockerfile#L42

bryanpaget commented 4 months ago

I thought this package was in the base images we use? see https://github.com/jupyter/docker-stacks/blob/main/images/base-notebook/Dockerfile#L42

I know! A new version was released May 06, which is the day our builds broke:

image

Further investigation may be required to truly understand how this broke our builds.

bryanpaget commented 4 months ago

I can confirm this issue has nothing to do with the upstream Docker images as I am able to build:

I am also able to build the refactored JupyterLab image:

bryanpaget commented 2 months ago

This is for main and no longer an issue.