Identify and enable Seldon network access in all AAW namespaces.

StatCan / aaw

Documentation for the Advanced Analytics Workspace Platform

https://statcan.github.io/aaw/

Other

67 stars 12 forks source link

Identify and enable Seldon network access in all AAW namespaces. #1028

Open chritter opened 2 years ago

chritter commented 2 years ago

Currently, Seldon deployments are not accessible due to network restrictions and require a special network setup, as identified and used in #798. The network settings need to be adapted for all namespaces.

Example use case to test: https://gitlab.com/dsd4/seldon_api_deploy/argo_seldon_deployments/-/tree/master/01_getting-started.

Specific goals:

Enable and refine setup for iris deployment example so that it works across all namespaces
Enable access via Seldon Python SDK as shown here. This requires configuring the python client appropriately.

chritter commented 2 years ago

Network policy label selector?

labels:
      notebook-name: seldondeployment

chritter commented 2 years ago

Preventing istio injection to allow init container with model to start:

  annotations:
    sidecar.istio.io/inject: "false"

chritter commented 2 years ago

-name: seldondeployment

Is not needed anymore according to Blair.

cboin1996 commented 2 years ago

Adding the annotation was to disable istio and thus avoid an istio injection that interferes with init containers.
The label is no longer needed.
- Why? currently these modifications to the deployment are manual and thus the istio injection is only necessary manually to run the SeldonDeployment.
In the future, perhaps a mutating webhook implementation could insert the annotation sidecar.istio.io/inject: "false" to SeldonDeployment's.

chuckbelisle commented 1 year ago

@Collinbrown95 this should be added to opt-in feature list

rohank07 commented 1 year ago

@chritter Can you please provide me a Seldon example notebook or deployment to test with - I cannot access the links provided above