search

StatCan / aaw

Documentation for the Advanced Analytics Workspace Platform
https://statcan.github.io/aaw/
Other
67 stars 12 forks source link

JupyterLab Git: Git Push UI Bug with Known Solution (Upgrade pexpect to 4.9.0) #1945

Closed StanHatko closed 5 months ago

StanHatko commented 5 months ago

When pushing to a git repo, an error with asyncio.coroutine not found occurs and the push fails. This is a known bug for the past couple of months or so.

Fortunately, a solution now exists, upgrade pexpect to version 4.9.0 (from 4.8.0). After running pip install --upgrade pexpect the updated pexpect was installed, and after that git push worked properly. Any user can run this in the base environment to fix it for themselves, but it would be better to do this system-wide.

Currently pexpect 4.9.0 is only available from PyPI pip, not conda-forge. I responded to https://github.com/conda-forge/pexpect-feedstock/pull/29 asking them to update the conda-forge version.

StanHatko commented 5 months ago

Screenshot before updating pexpect in the base environment (old version 4.8.0): image

Screenshot after updating pexpect to 4.9.0: image

StanHatko commented 5 months ago

The version in conda-forge is now updated to 4.9.0 (with the bug fixed) as well https://anaconda.org/conda-forge/pexpect.

mathis-marcotte commented 5 months ago

Thanks @StanHatko for looking into the solution for this issue!

mathis-marcotte commented 5 months ago

Confirmed the behavior. I cloned a repo, created a new branch and tried to push using the "Push to remote" from the UI "Git" tab, and I get the same error message. image

I also tried just pushing through the terminal, it's not working, giving me a 403. But that might just be me not authenticating properly, But I'm using the same username and Personal Access Token that I used for the UI git push authenticating, so I don't know what is up with that.

mathis-marcotte commented 5 months ago

Added a force install for the pexpect package to version 4.9.0. image

And after finally making a valid Personal Access Token, the push successfully happens image

mathis-marcotte commented 5 months ago

Jupyter images should now be updated to have this issue fixed.