RStudio/RStudio#9083 for initial discussion with upstream project on strategy
Statcan/kubeflow-containers#149 for description of initial work/discussion
ca-scribner/rstudio#1 for actual code (initial work was done on this i18n branch of this fork. Link is to a PR just for easy comparison. Some of these changes are now merged in to RStudio)
Brute force inspection of incorrect localization #816
Notes/gotchas:
~RStudio switched their default branch from master to main sometime after the fork was created, so branches like i18n are expecting to relate back to master and need to be rebased. Just be careful when doing any merges.~ Not relevant to new fork, only for existing PRs until they are merged in
user-state-schema.json/user-prefs-schema.json see this comment for more info, and here for preliminary work in this area (small updates to the json file and the resulting auto-generated .hpp and .cpp files)
[x] Update generate-prefs.R to emit java/gwt constants/properties files (see i18n branch of ca-scribner repo for intermediate work.)
[x] #611
Global Options menus
Options -> Code (EditingPreferencesPane.java)
[x] Use text from user-prefs-schema.json to prevent duplicate text/translation effort (existing code has text hard coded here plus defined in the .json)
[x] Checkboxes
[x] Enumerators
[x] Statically defined headings/other misc items TBD
[x] #762
[x] (#513) All other menus (Options -> *) (see i18n branch of ca-scribner repo for example of EditingPreferencesPane as mentioned above. This should be similar)
[x] #755
All other static strings in .java files:
[x] Basic proof of concept (using AboutDialog.java) (merged to upstream)
[x] #710
[x] #715
[x] #717
[x] #716
[x] #718
[x] #719
[x] #720
[x] #721
[x] #726
[x] #727
[x] #728
[x] #732
[x] #733
[x] #734
[x] #735
[x] #736
Other cleanup tasks
[x] (#511) First pass through strings, removing/annotating strings that are obviously ok (things like enumerator keys, etc) (see issue for WIP)
[x] #692 i18n-ify all remaining true positives (see #511 for starting point)
[x] Find any address any // i18n comments (see #511 for starting point)
[x] Find any address any // DEBUG comments (see #511 for starting point)
Tracking issue for RStudio i18n work
Discussions:
Notes/gotchas:
~RStudio switched their default branch from
master
tomain
sometime after the fork was created, so branches like i18n are expecting to relate back to master and need to be rebased. Just be careful when doing any merges.~ Not relevant to new fork, only for existing PRs until they are merged ini18n tasks:
Commands.cmd.xml
(see #553):user-state-schema.json
/user-prefs-schema.json
see this comment for more info, and here for preliminary work in this area (small updates to the json file and the resulting auto-generated .hpp and .cpp files)generate-prefs.R
to emit java/gwt constants/properties files (see i18n branch of ca-scribner repo for intermediate work.)Options -> Code
(EditingPreferencesPane.java
)user-prefs-schema.json
to prevent duplicate text/translation effort (existing code has text hard coded here plus defined in the.json
)Options -> *
) (see i18n branch of ca-scribner repo for example of EditingPreferencesPane as mentioned above. This should be similar)// i18n
comments (see #511 for starting point)// DEBUG
comments (see #511 for starting point)Upstreaming:
552 Enable i18n and make trivial translations