StatCan / datascience-cookiecutter

A Cookiecutter template for Data Science Projects in Python
MIT License
7 stars 1 forks source link

Build error in default toml config #58

Closed goatsweater closed 1 year ago

goatsweater commented 1 year ago

The default pyproject.toml configuration results in build error because the license-files key is changed by PEP 639. The default CI configuration fails with this error:

ValueError: invalid pyproject.toml config: `project`.
configuration error: `project` must not contain {'license-files'} properties

The key can simply be removed. It defaults to recognizing the presence of the LICENSE file at the root of the repo so no need to be explicit by specifying it.

goatsweater commented 1 year ago

Somewhat unrelated but still results in an error from the default CI is a missing directory pointer in the default Python unit testing stage: ERROR: You must give at least one requirement to install

pip install --disable-pip-version-check --find-links pkg[tests]

should be

pip install --disable-pip-version-check --find-links . pkg[tests]

Note the reference to current directory (.) after the --find-links option.