search

StatCan / jupyter-apis

A Golang replacement for the Kubeflow Jupyter Web APIs / Un remplacement Golang pour les API de Web de Jupyter, partie de Kubeflow
Other
13 stars 4 forks source link

fix volume delete icon hover message #282

Closed mathis-marcotte closed 1 year ago

mathis-marcotte commented 1 year ago

The hover message is inaccurate. It is always showing this message when the button is disabled, even when the pvc is not terminating.

image

Seems like this is because the status of the notebooks are being set to "TERMINATING" instead of "UNAVAILABLE"

On a side note, the delete-button component is not translated.

mathis-marcotte commented 1 year ago

seems like we just need a way to actually use this function

mathis-marcotte commented 1 year ago

It looks like the issue was that the function to set the status of pvcs was not updated properly with the new 1.7 update.

mathis-marcotte commented 1 year ago

This is what the message should of looked like image