search

StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

feat: update vs code #15

Closed frazs closed 4 years ago

frazs commented 4 years ago

Resolves https://github.com/StatCan/kubeflow-containers/issues/60

Note that #10 also changes vs-code-desktop.sh in order to pass a new checksum and build. That is because the original code uses a download link that always gets the latest version (and will thus fail an older checksum and stop the build for every update). In case of a merge conflict, the vs-code-desktop.sh from this PR should be used, which specifies a version.

Note that due to a change in installation directories as part of the vs-code-server.sh update, the file resources/supervisor/programs/vscode.conf has changed. However, in #10, as part of streamlining supervisor configuration*, the directory resources/supervisor/programs has been renamed to resources/supervisor/conf.d to better reflect its ultimate destination of /etc/supervisor/conf.d inside the image. In case of a merge conflict:

  1. Use resources/supervisor/programs/vscode.conf from this PR to replace resources/supervisor/conf.d/vscode.conf in #10, but keep the location as resources/supervisor/conf.d/vscode.conf.
  2. Use all the other supervisor program .conf files from #10, keeping their locations in resources/supervisor/conf.d/.
  3. Delete resources/supervisor/programs/.

I was considering adding that streamlining here (at least as far as the directory change), but the original supervisor-related code is very chaotic (e.g. defined across multiple layers) and wrapped up in various permissions considerations. I concluded that doing so could actually be more* confusing and create further merge conflicts.

chritter commented 4 years ago

@frazs This is great as i was missing certain VSCode extensions not supported in the old version. That implies we have the latest version in all ml-workspace images? I might update our project image which depends on this one then.

frazs commented 4 years ago

Not quite yet. I am waiting on a major PR to be merged in, and then I will update the remote-desktop images available in the Create Notebook Server drop-down. This is because building is still manual (hopefully changed soon), and that PR is a major enough divergence from master (but one I've been building on top of for weeks) that it would interfere with testing.

I will let you know when updated images are available. Note that ml-workspace-rstudio and ml-workspace-geomatics have also been renamed to remote-desktop-r and remote-desktop-geomatics: you will need to update the FROM in any custom image extensions to match.