search

StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

feat: add ci #18

Closed frazs closed 4 years ago

frazs commented 4 years ago

Resolves https://github.com/StatCan/kubeflow-containers/issues/62

Question: this is based on https://github.com/StatCan/kubeflow-containers/blob/master/.github/workflows/build.yml. However, therein there is a difference in the docker build line for some images.

For example, minimal-notebook ends in . : docker build -f minimal-notebook/cpu/Dockerfile -t ${{ env.REGISTRY_NAME }}.azurecr.io/minimal-notebook-cpu:${{ github.sha }} .

But base-notebook ends in base-notebook/cpu: docker build -f base-notebook/cpu/Dockerfile -t ${{ env.REGISTRY_NAME }}.azurecr.io/base-notebook-cpu:${{ github.sha }} base-notebook/cpu

I would like to confirm what this difference means, and thus if it should be applied anywhere here (e.g. remote-desktop/r?)

frazs commented 4 years ago

Figured out the question I had: the last part, which I just updated from . to base, r, and geomatics respectively in the latest commit, specifies the build working directory for the purpose of e.g. COPY commands.