StatCan / kubeflow-containers-desktop

Experimental containers to be used with Kubeflow for a Desktop experience
Other
1 stars 2 forks source link

python packages as in non-ml-workspace images #19

Closed chritter closed 4 years ago

chritter commented 4 years ago

Hello, On the non ml-workspace images we have a variety of extensions enabled, including those to supporting Python styles. Could we have these extensions installed on the desktop images as well?

Thanks!

blairdrummond commented 4 years ago

What do you mean by "Python Styles" and what kinds of extensions? Just pip packages?

chritter commented 4 years ago

Yes, the Jupyter extensions, most importantly

Thanks!

frazs commented 4 years ago

I'm not sure what these are or where they are defined

ca-scribner commented 4 years ago

hey @blairdrummond / @chritter , do you know which extensions are missing (or is this still an issue)? @saffaalvi is available to work on this but we weren't sure which extensions are needed

blairdrummond commented 4 years ago

Mostly referring to these;

https://github.com/StatCan/kubeflow-containers/blob/35745bc39e0c63fd3fbf29acbf165926ca1d09a1/minimal-notebook/cpu/Dockerfile#L52-L112

The commenting extension actually isn't in the main image yet, to the best of my knowledge. But it's also a great addition!

blairdrummond commented 4 years ago

I'm not sure which extensions are most important, but that's the global list

ca-scribner commented 4 years ago

Is there any reason we can’t have a shared base extension list for all our core notebook images? They fee very bespoke atm

On Wed, Jul 15, 2020 at 12:08 Blair Drummond notifications@github.com wrote:

I'm not sure which extensions are most important, but that's the global list

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StatCan/kubeflow-containers-desktop/issues/19#issuecomment-658841863, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPFPI4GSIIDFHI5GFZJ2HTR3XH7ZANCNFSM4OE2DO4Q .

frazs commented 4 years ago

Wait a sec: it's my impression that we've decided to completely remove jupyterlab from remote-desktop (the images that used to be called ml-workspace), and were considering removing jupyter as well. These appear to be jupyterlab extensions...?

chritter commented 4 years ago

@frazs Please do not remove Jupyter from the ml-workspace image! It is a great capability we are using daily in the construction starts project. I like @ca-scribner to have a list of base extensions, which should include the linting support, debugging feature, git and more.

frazs commented 4 years ago

Closing this issue as the current direction is that JupyterLab and its extensions will not be in the official Remote Desktop images.

Solutions for sharing storage between different images are in the works (https://github.com/StatCan/daaas/issues/194 and https://github.com/StatCan/daaas/issues/133), such that in the future it should become possible to have specialized JupyterLab images accessing the same data alongside Remote Desktop images.

In the meantime, as we have discussed, I have made available an experimental placeholder version of Remote Desktop geomatics for your team that does include JupyterLab and its extensions. It will be decommissioned once multi-image shared storage is ready and confirmed working.